STOR-3014: Promote SELinuxMountGAReadiness to GA by jsafrane · Pull Request #2964 · openshift/api

jsafrane · 2026-07-30T15:38:26Z

Promote the gate to GA.

Enhancement: https://github.com/openshift/enhancements/blob/master/enhancements/storage/selinuxmount-ga-block-upgrade.md

There are only 4 tests. This was acknowledged during the enhancement review (there are not so many different cases to test).
The test are running in -serial jobs and therefore hypershift is missing.
metal is missing because it does not have any storage

openshift-merge-bot · 2026-07-30T15:38:28Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-07-30T15:38:30Z

@jsafrane: This pull request references STOR-3014 which is a valid jira issue.

Details

In response to this:

Promote the gate to GA.

Starting as a draft, the CI tests got merged a day or two ago. Checking if everything works and the tests work.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-07-30T15:38:34Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2026-07-30T15:38:37Z

Hello @jsafrane! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

coderabbitai · 2026-07-30T15:38:46Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b232f824-fbfe-4bf6-82ae-13d94232048a

📥 Commits

Reviewing files that changed from the base of the PR and between 6d3854a and 18b6a38.

📒 Files selected for processing (6)

features.md
features/features.go
payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

🚧 Files skipped from review as they are similar to previous changes (6)

payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
features.md
features/features.go
payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

📝 Walkthrough

Walkthrough

SELinuxMountGAReadiness now enables for Default and OKD feature sets. The related HyperShift and SelfManagedHA manifests move it from disabled lists to enabled lists. The documentation table relocates the feature-gate row.

Suggested reviewers: joelspeed, everettraven

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly states the main change: promoting SELinuxMountGAReadiness to GA.
Description check	✅ Passed	The description directly explains the feature-gate promotion and provides related test coverage context.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The six-file patch changes feature metadata and manifests only; it adds or modifies no test files or Ginkgo title calls, so no unstable test name is present.
Test Structure And Quality	✅ Passed	The PR changes only feature metadata, Go gate registration, and generated manifests; it adds no Ginkgo test code, so the test-structure criteria do not apply.
Microshift Test Compatibility	✅ Passed	The patch changes only feature-gate documentation, registration, and manifests; it adds no Ginkgo e2e tests that require MicroShift compatibility review.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The patch changes only feature metadata, Go feature-gate registration, and YAML manifests; it adds no Ginkgo tests or test-like files requiring SNO compatibility review.
Topology-Aware Scheduling Compatibility	✅ Passed	The patch only changes feature-gate registration, documentation, and FeatureGate status lists; it adds no deployments, controllers, pods, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The patch changes feature metadata and manifests only; no process-level Go code or stdout-writing call is added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The commit changes only feature metadata, Go feature-gate registration, and YAML manifests; it adds no Ginkgo test files or test declarations requiring IPv4 or external connectivity review.
No-Weak-Crypto	✅ Passed	The commit changes only feature-gate metadata and manifests; no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons were added.
Container-Privileges	✅ Passed	The six changed files only update feature-gate registration and FeatureGate status lists; no privileged, host namespace, SYS_ADMIN, securityContext, or escalation fields were added.
No-Sensitive-Data-In-Logs	✅ Passed	The patch only changes feature-gate metadata, documentation, and manifest membership; it adds no logging or runtime output and contains no sensitive data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

_{Comment @coderabbitai help to get the list of available commands.}

jsafrane · 2026-07-30T15:38:57Z

/test verify-feature-promotion

openshift-ci · 2026-07-30T15:39:36Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

qodo-for-rh-openshift · 2026-07-30T15:39:48Z

PR-Agent: could not find a component named verify-feature-promotion in a supported language in this PR.

jsafrane · 2026-07-30T15:43:54Z

/test verify-feature-promotion

qodo-for-rh-openshift · 2026-07-30T15:44:38Z

PR-Agent: could not find a component named verify-feature-promotion in a supported language in this PR.

jsafrane · 2026-07-31T13:50:35Z

/test verify-feature-promotion

there should be metal-serial job

qodo-for-rh-openshift · 2026-07-31T13:51:20Z

PR-Agent: could not find a component named verify-feature-promotion in a supported language in this PR.

jsafrane · 2026-08-03T08:16:28Z

/test verify-feature-promotion

qodo-for-rh-openshift · 2026-08-03T08:17:20Z

PR-Agent: could not find a component named verify-feature-promotion in a supported language in this PR.

qodo-for-rh-openshift · 2026-08-03T14:01:11Z

PR Summary by Qodo

Promote SELinuxMountGAReadiness feature gate to GA defaults

✨ Enhancement ⚙️ Configuration changes 📝 Documentation 🕐 10-20 Minutes

AI Description

• Enable SELinuxMountGAReadiness in default and OKD feature gate sets (GA promotion).
• Move SELinuxMountGAReadiness into the GA-enabled payload FeatureGate manifests for 4.10.
• Update feature gate documentation table to reflect GA/default enablement.

Diagram

graph TD
  A["features/features.go"] --> B["FeatureGate registry"] --> C["Default + OKD enablement"] --> D["payload-manifests/featuregates/*4-10*.yaml"] --> E["Cluster FeatureGate config"]
  B --> F["features.md"]

High-Level Assessment

The PR uses the standard mechanism for GA promotion: enabling the gate in the default/OKD sets in the feature registry and aligning the shipped payload manifests and docs. Alternatives like removing the gate entirely (instead of promoting it) would be more disruptive for version skew/backward compatibility and are not warranted here.

Files changed (6) +14 / -14

Enhancement (1) +1 / -1

features.goEnable SELinuxMountGAReadiness in default and OKD sets +1/-1

Enable SELinuxMountGAReadiness in default and OKD sets

• Changes the SELinuxMountGAReadiness feature gate registration to include inDefault() and inOKD() enablement in addition to existing preview/no-upgrade sets. This is the primary GA promotion switch in code.

features/features.go

Documentation (1) +1 / -1

features.mdReflect SELinuxMountGAReadiness as GA-enabled in feature matrix +1/-1

Reflect SELinuxMountGAReadiness as GA-enabled in feature matrix

• Updates the feature matrix entry placement for SELinuxMountGAReadiness to match GA/default enablement. Ensures documentation aligns with the promoted enablement status.

features.md

Other (4) +12 / -12

featureGate-4-10-Hypershift-Default.yamlMove SELinuxMountGAReadiness into GA-enabled section (Hypershift Default) +3/-3

Move SELinuxMountGAReadiness into GA-enabled section (Hypershift Default)
• Removes SELinuxMountGAReadiness from the earlier list section and adds it to the GA-enabled feature list section near other enabled-by-default gates. Aligns the Hypershift Default 4.10 payload with GA promotion.
payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

featureGate-4-10-Hypershift-OKD.yamlMove SELinuxMountGAReadiness into GA-enabled section (Hypershift OKD) +3/-3

Move SELinuxMountGAReadiness into GA-enabled section (Hypershift OKD)
• Mirrors the Hypershift Default change for OKD payload manifests by relocating SELinuxMountGAReadiness into the GA-enabled portion of the list. Keeps OKD payload consistent with the registry enablement.
payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml

featureGate-4-10-SelfManagedHA-Default.yamlMove SELinuxMountGAReadiness into GA-enabled section (SelfManagedHA Default) +3/-3

Move SELinuxMountGAReadiness into GA-enabled section (SelfManagedHA Default)
• Relocates SELinuxMountGAReadiness into the GA-enabled section of the SelfManagedHA Default 4.10 feature gate payload. Ensures self-managed HA profile ships the gate as enabled by default.
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml

featureGate-4-10-SelfManagedHA-OKD.yamlMove SELinuxMountGAReadiness into GA-enabled section (SelfManagedHA OKD) +3/-3

Move SELinuxMountGAReadiness into GA-enabled section (SelfManagedHA OKD)
• Relocates SELinuxMountGAReadiness into the GA-enabled portion of the OKD self-managed HA 4.10 payload manifest. Maintains parity across Default vs OKD payloads for GA promotion.
payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

qodo-for-rh-openshift · 2026-08-03T14:04:20Z

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

_{To customize comments, go to the Qodo configuration screen, or learn more in the docs.}

jsafrane · 2026-08-04T14:45:20Z

/test verify-feature-promotion

qodo-for-rh-openshift · 2026-08-04T14:46:15Z

PR-Agent: could not find a component named verify-feature-promotion in a supported language in this PR.

jsafrane · 2026-08-05T08:17:40Z

/test verify-feature-promotion
there should be some hypershift coverage

qodo-for-rh-openshift · 2026-08-05T08:23:15Z

PR-Agent: could not find a component named verify-feature-promotion in a supported language in this PR.

openshift-ci · 2026-08-07T11:47:59Z

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-hypershift-integration	`18b6a38`	link	true	`/test verify-hypershift-integration`
ci/prow/verify-feature-promotion	`18b6a38`	link	true	`/test verify-feature-promotion`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 30, 2026

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2026

openshift-ci Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 30, 2026

jsafrane force-pushed the promote-selinuxmountgareadiness branch from 6da247f to 6d3854a Compare July 30, 2026 15:42

openshift-ci Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 30, 2026

jsafrane marked this pull request as ready for review August 3, 2026 13:59

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2026

openshift-ci Bot requested review from JoelSpeed and everettraven August 3, 2026 14:01

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2026

Promote SELinuxMountGAReadiness to GA

18b6a38

jsafrane force-pushed the promote-selinuxmountgareadiness branch from 6d3854a to 18b6a38 Compare August 7, 2026 10:46

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2026

Uh oh!

Conversation

jsafrane commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-merge-bot Bot commented Jul 30, 2026

Uh oh!

openshift-ci-robot commented Jul 30, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Jul 30, 2026

Uh oh!

openshift-ci Bot commented Jul 30, 2026

Uh oh!

coderabbitai Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Uh oh!

jsafrane commented Jul 30, 2026

Uh oh!

openshift-ci Bot commented Jul 30, 2026

Uh oh!

qodo-for-rh-openshift Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsafrane commented Jul 30, 2026

Uh oh!

qodo-for-rh-openshift Bot commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsafrane commented Jul 31, 2026

Uh oh!

qodo-for-rh-openshift Bot commented Jul 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsafrane commented Aug 3, 2026

Uh oh!

qodo-for-rh-openshift Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qodo-for-rh-openshift Bot commented Aug 3, 2026

PR Summary by Qodo

Uh oh!

qodo-for-rh-openshift Bot commented Aug 3, 2026

Code Review by Qodo

Great, no issues found!

Uh oh!

jsafrane commented Aug 4, 2026

Uh oh!

qodo-for-rh-openshift Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jsafrane commented Aug 5, 2026

Uh oh!

qodo-for-rh-openshift Bot commented Aug 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Aug 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jsafrane commented Jul 30, 2026 •

edited

Loading

openshift-ci-robot commented Jul 30, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Jul 30, 2026 •

edited

Loading

qodo-for-rh-openshift Bot commented Jul 30, 2026 •

edited

Loading

qodo-for-rh-openshift Bot commented Jul 30, 2026 •

edited

Loading

qodo-for-rh-openshift Bot commented Jul 31, 2026 •

edited

Loading

qodo-for-rh-openshift Bot commented Aug 3, 2026 •

edited

Loading

qodo-for-rh-openshift Bot commented Aug 4, 2026 •

edited

Loading

qodo-for-rh-openshift Bot commented Aug 5, 2026 •

edited

Loading